linux-kernel - Re: [PATCH 1/2] ASoC: audio-graph: Export graph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   04 Feb 2021 07:33:37 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Sameer Pujar <spujar@...dia.com>, thierry.reding@...il.com,
        jonathanh@...dia.com, alsa-devel@...a-project.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        sharadg@...dia.com
Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function


Hi

> > > > +int graph_remove(struct platform_device *pdev);
> 
> > > I think this needs better namespacing if it's going to be exported.
> 
> > audio_graph_remove() can be a better choice?
> 
> Yeah, that looks reasonable.

Nice naming I think.
In such case,  update also graph_parse_of() is nice idea for me.

	- int graph_parse_of(...)
	+ int audio_graph_parse_of()

Thank you for your help !!

Best regards
---
Kuninori Morimoto