linux-kernel - Re: [PATCH net-next v2 0/7] net: ipa: don't disable NAPI in suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210202200802.49c5d7a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 2 Feb 2021 20:08:02 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Alex Elder <elder@...aro.org>
Cc:     David Miller <davem@...emloft.net>, elder@...nel.org,
        evgreen@...omium.org, bjorn.andersson@...aro.org,
        cpratapa@...eaurora.org,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 0/7] net: ipa: don't disable NAPI in suspend

On Mon, 1 Feb 2021 13:44:20 -0500 Willem de Bruijn wrote:
> On Mon, Feb 1, 2021 at 12:28 PM Alex Elder <elder@...aro.org> wrote:
> >
> > This is version 2 of a series that reworks the order in which things
> > happen during channel stop and suspend (and start and resume), in
> > order to address a hang that has been observed during suspend.
> > The introductory message on the first version of the series gave
> > some history which is omitted here.
> >
> > The end result of this series is that we only enable NAPI and the
> > I/O completion interrupt on a channel when we start the channel for
> > the first time.  And we only disable them when stopping the channel
> > "for good."  In other words, NAPI and the completion interrupt
> > remain enabled while a channel is stopped for suspend.
> >
> > One comment on version 1 of the series suggested *not* returning
> > early on success in a function, instead having both success and
> > error paths return from the same point at the end of the function
> > block.  This has been addressed in this version.
> >
> > In addition, this version consolidates things a little bit, but the
> > net result of the series is exactly the same as version 1 (with the
> > exception of the return fix mentioned above).
> >
> > First, patch 6 in the first version was a small step to make patch 7
> > easier to understand.  The two have been combined now.
> >
> > Second, previous version moved (and for suspend/resume, eliminated)
> > I/O completion interrupt and NAPI disable/enable control in separate
> > steps (patches).  Now both are moved around together in patch 5 and
> > 6, which eliminates the need for the final (NAPI-only) patch.
>
> Acked-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks!