linux-kernel - Re: [PATCH v4] misc: bcm-vk: only support ttyVK if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac337905-9bf0-32c6-f98c-5912de1d6655@infradead.org>
Date:   Wed, 3 Feb 2021 15:18:15 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Scott Branden <scott.branden@...adcom.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Olof Johansson <olof@...om.net>,
        Desmond Yan <desmond.yan@...adcom.com>
Subject: Re: [PATCH v4] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set

On 2/3/21 2:38 PM, Scott Branden wrote:
> Correct compile issue if CONFIG_TTY is not set by
> only adding ttyVK devices if CONFIG_BCM_VK_TTY is set.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Scott Branden <scott.branden@...adcom.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested


Thanks.

> 
> ---
> Changes since v3:
> - Kconfig cleanups below as per Greg's comments
> - changed if BCM_VK to depends on BCM_VK
> - removed default y in CONFIG_BCM_VK_TTY
> - expanded decription of CONFIG_BCM_VK_TTY
> Changes since v2:
> - add CONFIG_BCM_VK_TTY
> - add function and stub for bcm_vk_tty_set_irq_enabled
> Changes since v1:
> - add function stubs rather than compiling out code
> ---
>  drivers/misc/bcm-vk/Kconfig      | 12 +++++++++
>  drivers/misc/bcm-vk/Makefile     |  4 +--
>  drivers/misc/bcm-vk/bcm_vk.h     | 42 +++++++++++++++++++++++++++++---
>  drivers/misc/bcm-vk/bcm_vk_dev.c |  5 ++--
>  drivers/misc/bcm-vk/bcm_vk_tty.c |  6 +++++
>  5 files changed, 61 insertions(+), 8 deletions(-)


-- 
~Randy