linux-kernel - RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Feb 2021 07:02:12 +0000
From:   "nakamura.shun@...itsu.com" <nakamura.shun@...itsu.com>
To:     'John Garry' <john.garry@...wei.com>,
        "will@...nel.org" <will@...nel.org>,
        "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "leo.yan@...aro.org" <leo.yan@...aro.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

Hi, John

> Just some things to note:
> - please pick up and apply reviewed-by tags granted from previous reviews if
> explicitly granted, subject to making any trivial changes requested If any
> significant changes are made, then don't pick up theses tags or drop them (if they
> were picked up earlier)
I will fix.

> - I'd say that it's best not to send my patch in 1/4, but better to mention the series
> which this is based on in your cover letter Sending my patch is only going to make
> the maintainers (Arnaldo) life more difficult to track these things.
I will fix.

> Apart from that, I think that we're a bit uncertain about patch 3/4
What are your concerns?
I think it's okay for perf to read a new event code with a number at the beginning.

Best Regards
Shunsuke