lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210202164612.00007509@intel.com> Date: Tue, 2 Feb 2021 16:46:12 -0800 From: Jesse Brandeburg <jesse.brandeburg@...el.com> To: Hariprasad Kelam <hkelam@...vell.com> Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <kuba@...nel.org>, <davem@...emloft.net>, <willemdebruijn.kernel@...il.com>, <andrew@...n.ch>, <sgoutham@...vell.com>, <lcherian@...vell.com>, <gakula@...vell.com>, <jerinj@...vell.com>, <sbhatta@...vell.com> Subject: Re: [Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status Hariprasad Kelam wrote: > From: Christina Jacob <cjacob@...vell.com> > > Register get_link_ksettings callback to get link status information > from the driver. As virtual function (vf) shares same physical link > same API is used for both the drivers and for loop back drivers > simply returns the fixed values as its does not have physical link. > > ethtool eth3 > Settings for eth3: > Supported ports: [ ] > Supported link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full > 1000baseT/Half 1000baseT/Full > 10000baseKR/Full > 1000baseX/Full > Supports auto-negotiation: No > Supported FEC modes: BaseR RS > Advertised link modes: Not reported > Advertised pause frame use: No > Advertised auto-negotiation: No > Advertised FEC modes: None > > ethtool lbk0 > Settings for lbk0: > Speed: 100000Mb/s > Duplex: Full > > Signed-off-by: Christina Jacob <cjacob@...vell.com> > Signed-off-by: Sunil Goutham <sgoutham@...vell.com> > Signed-off-by: Hariprasad Kelam <hkelam@...vell.com> besides the slightly long lines, looks good. Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
Powered by blists - more mailing lists