linux-kernel - Re: [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa1dc788-bc47-ac8e-73a9-067be8b6ba7a@suse.de>
Date:   Wed, 3 Feb 2021 09:20:21 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Ye Bin <yebin10@...wei.com>, bskeggs@...hat.com, airlied@...ux.ie,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init

Applied to drm-misc-next. Thanks for the patch!

Am 23.01.21 um 02:30 schrieb Ye Bin:
> Fix follow warning:
> drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable]
>    struct pci_dev *pdev;
>                    ^~~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ye Bin <yebin10@...wei.com>
> ---
>   drivers/gpu/drm/nouveau/nouveau_bios.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 7cc683b8dc7a..e8c445eb1100 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev)
>   {
>   	struct nouveau_drm *drm = nouveau_drm(dev);
>   	struct nvbios *bios = &drm->vbios;
> -	struct pci_dev *pdev;
>   	int ret;
>   
>   	/* only relevant for PCI devices */
>   	if (!dev_is_pci(dev->dev))
>   		return 0;
> -	pdev = to_pci_dev(dev->dev);
>   
>   	if (!NVInitVBIOS(dev))
>   		return -ENODEV;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)