linux-kernel - Re: [BUG] copy_file_range with sysfs file as input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Feb 2021 17:18:19 +0800
From:   Nicolas Boichat <drinkcat@...omium.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     "Darrick J. Wong" <djwong@...nel.org>,
        linux-fsdevel@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
        Amir Goldstein <amir73il@...il.com>,
        Dave Chinner <dchinner@...hat.com>,
        Luis Lozano <llozano@...omium.org>,
        Ian Lance Taylor <iant@...gle.com>
Subject: Re: [BUG] copy_file_range with sysfs file as input

On Wed, Feb 3, 2021 at 5:04 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Mon, Jan 25, 2021 at 03:54:31PM +0800, Nicolas Boichat wrote:
> > Hi copy_file_range experts,
> >
> > We hit this interesting issue when upgrading Go compiler from 1.13 to
> > 1.15 [1]. Basically we use Go's `io.Copy` to copy the content of
> > `/sys/kernel/debug/tracing/trace` to a temporary file.
>
> Nit, the above file is NOT a sysfs file.  Odds are it is either a
> debugfs, or a tracefs file, please check your mounts to determine which
> it is, as that matters a lot on the kernel backend side for trying to
> figure out what is going on here :)

Yes yes it's tracefs ,-) But, from the other thread
https://lkml.org/lkml/2021/1/26/2029 sysfs (and any other fs that
generates files dynamically like procfs) would likely hit issues as
well (but maybe in more rare circumstances).

Thanks!

>
> thanks,
>
> greg k-h