linux-kernel - Re: [PATCH] gpio: pca953x: add support for open drain pins on PCAL6524

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcPeJOrX0A3DLM8Z0v-H2xVd0TrrssEXe5ZMOFcspsrfQ@mail.gmail.com>
Date:   Wed, 3 Feb 2021 12:12:52 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Alban Bedel <alban.bedel@...q.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: add support for open drain pins on PCAL6524

On Tue, Feb 2, 2021 at 1:45 PM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
> On Thu, Jan 28, 2021 at 4:36 PM Alban Bedel <alban.bedel@...q.com> wrote:
> >
> > From a quick glance at various datasheet the PCAL6524 seems to be the

Oh, even more typos

datasheets

> > only chip in this familly that support setting the drive mode of

supports

> > single pins. Other chips either don't support it at all, or can only
> > set the drive mode of whole banks, which doesn't map to the GPIO API.
> >
> > Add a new flag, PCAL6524, to mark chips that have the extra registers
> > needed for this feature. Then mark the needed register banks as
> > readable and writable, here we don't set OUT_CONF as writable,
> > although it is, as we only need to read it. Finally add a function
> > that configure the OUT_INDCONF register when the GPIO API set the
> > drive mode of the pins.

...

> Maybe call it PCAL6524_TYPE for consistency with the ones below?

In case you continue modifying this driver, I agree with Bart on
PCAL6524_TYPE along with new OF_6524() macro.

-- 
With Best Regards,
Andy Shevchenko