linux-kernel - Re: [PATCH] mm/slub: embed __slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9A811B32-6E3D-4FE1-98A5-A7922C32CDB4@icloud.com>
Date:   Wed, 3 Feb 2021 09:41:58 +0800
From:   Abel Wu <abel.w@...oud.com>
To:     Christoph Lameter <cl@...ux.com>
Cc:     Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>, hewenliang4@...wei.com,
        wuyun.wu@...wei.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slub: embed __slab_alloc to its caller

> On Feb 2, 2021, at 6:11 PM, Christoph Lameter <cl@...ux.com> wrote:
> 
> On Tue, 2 Feb 2021, Abel Wu wrote:
> 
>> Since slab_alloc_node() is the only caller of __slab_alloc(), embed
>> __slab_alloc() to its caller to save function call overhead. This
>> will also expand the caller's code block size a bit, but hackbench
>> tests on both host and guest didn't show a difference w/ or w/o
>> this patch.
> 
> slab_alloc_node is an always_inline function. It is intentional that only
> the fast path was inlined and not the slow path.

Oh I got it. Thanks for your excellent explanation.

Best Regards,
	Abel