linux-kernel - Re: [PATCH] nvme: Add 48-bit DMA address quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de>
Date:   Wed, 3 Feb 2021 12:12:31 +0100
From:   Filippo Sironi <sironi@...zon.de>
To:     Christoph Hellwig <hch@....de>
CC:     <serebrin@...zon.com>, <dwmw@...zon.co.uk>, <kbusch@...nel.org>,
        <axboe@...com>, <sagi@...mberg.me>,
        <linux-nvme@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk

On 2/3/21 10:51 AM, Christoph Hellwig wrote:
> 
> On Wed, Feb 03, 2021 at 10:43:38AM +0100, Filippo Sironi wrote:
>> Certain NVMe controllers don't support 64-bit DMA addresses.  Instead,
>> they are limited to 48-bit DMA addresses.  Let's add a quirk to use them
>> properly.
> 
> WTF?  This is such a grave NVMe spec compiance bug that I do not think
> we should support this buggy mess in Linux.
> 

I don't disagree on the first part of your sentence, this is a big 
oversight.

On the other hand, those controllers are out there and are in use by a 
lot of customers.  We can keep relying on luck, hoping that customers 
don't run into troubles or we can merge a few lines of code :)

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879