linux-kernel - Re: [PATCH] nvme: Add 48-bit DMA address quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <396b45d5-3dd5-8159-34c2-5668510d1d68@amazon.de>
Date:   Wed, 3 Feb 2021 12:22:31 +0100
From:   Filippo Sironi <sironi@...zon.de>
To:     Christoph Hellwig <hch@....de>
CC:     <serebrin@...zon.com>, <dwmw@...zon.co.uk>, <kbusch@...nel.org>,
        <axboe@...com>, <sagi@...mberg.me>,
        <linux-nvme@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk

On 2/3/21 12:15 PM, Christoph Hellwig wrote:
> 
> On Wed, Feb 03, 2021 at 12:12:31PM +0100, Filippo Sironi wrote:
>> I don't disagree on the first part of your sentence, this is a big
>> oversight.
> 
> But it is not what your commit log suggests.

I can definitely rephrase the commit.

>> On the other hand, those controllers are out there and are in use by a lot
>> of customers.  We can keep relying on luck, hoping that customers don't run
>> into troubles or we can merge a few lines of code :)
> 
> Your patch does not just quirk a few controllers out there, but all
> current and future controllers with an Amazon vendor ID.  We could
> probably talk about quirking an existing vendor ID or two as long as
> this doesn't happen for future hardware.

I know that the hardware team is working on this but I don't know the 
timelines and there are a few upcoming controllers - of which I don't 
know the device ids yet - that have the same issue.

To avoid issues, it is easier to apply the quirk to all Amazon NVMe 
controllers for now till the new lines of controllers with the fix comes 
out.  At that point, we'll be able to restrict the application to the 
known bad controllers.

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879