linux-kernel - Re: [PATCH v3 15/22] dt-bindings: media: camss: Add qcom, sdm660-camss binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Feb 2021 12:23:30 +0100
From:   Robert Foss <robert.foss@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     michael@...le.cc, leoyang.li@....com,
        linux-media <linux-media@...r.kernel.org>,
        Todor Tomov <todor.too@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Sarvesh Sridutt <Sarvesh.Sridutt@...rtwirelesscompute.com>,
        Azam Sadiq Pasha Kapatrala Syed <akapatra@...cinc.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Andrey Konovalov <andrey.konovalov@...aro.org>,
        Anson.Huang@....com, Geert Uytterhoeven <geert+renesas@...der.be>,
        Arnd Bergmann <arnd@...db.de>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Jonathan Marek <jonathan@...ek.ca>, shawnguo@...nel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        AngeloGioacchino Del Regno <kholk11@...il.com>,
        agx@...xcpu.org, Tomasz Figa <tfiga@...omium.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, MSM <linux-arm-msm@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        angelogioacchino.delregno@...ainline.org, max.oss.09@...il.com,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Will Deacon <will@...nel.org>, Andy Gross <agross@...nel.org>
Subject: Re: [PATCH v3 15/22] dt-bindings: media: camss: Add qcom,
 sdm660-camss binding

On Sat, 30 Jan 2021 at 18:23, Rob Herring <robh@...nel.org> wrote:
>
> On Wed, 27 Jan 2021 15:49:23 +0100, Robert Foss wrote:
> > Add bindings for qcom,sdm660-camss in order to support the camera
> > subsystem on SDM630/660 and SDA variants.
> >
> > Signed-off-by: Robert Foss <robert.foss@...aro.org>
> > ---
> >
> > Changes since v2
> >  - Rob: Add new line at end of file
> >  - Rob: Remove redundant descriptions
> >  - Rob: Add power domain description
> >  - Rob: Make clock-lanes a constant
> >  - Rob: Rework to conform to new port schema
> >  - Add max & minItems to data-lanes
> >  - Remove ports requirement - endpoint & reg
> >  - Added Angelo as binding maintainer
> >  - Removed Todor as binding maintainer
> >
> >
> >  .../bindings/media/qcom,sdm660-camss.yaml     | 398 ++++++++++++++++++
> >  1 file changed, 398 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/media/qcom,sdm660-camss.example.dts:21:18: fatal error: dt-bindings/clock/qcom,mmcc-sdm660.h: No such file or directory
>    21 |         #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/media/qcom,sdm660-camss.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1370: dt_binding_check] Error 2

This is expected and mentioned in the cover letter due to a dependency
on an as of yet unmerged mmcc-sdm660 series.

>
> See https://patchwork.ozlabs.org/patch/1432255
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>