linux-kernel - Re: [PATCH] scsi: target: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Feb 2021 01:59:06 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>,
        "bootc@...tc.net" <bootc@...tc.net>
CC:     "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "linux1394-devel@...ts.sourceforge.net" 
        <linux1394-devel@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: target: remove unneeded semicolon

On 2/2/21 17:52, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/target/sbp/sbp_target.c:1009:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/target/sbp/sbp_target.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
> index e4a9b9f..2a6165f 100644
> --- a/drivers/target/sbp/sbp_target.c
> +++ b/drivers/target/sbp/sbp_target.c
> @@ -1006,7 +1006,7 @@ static void tgt_agent_fetch_work(struct work_struct *work)
>  			agent->state = AGENT_STATE_SUSPENDED;
>  
>  		spin_unlock_bh(&agent->lock);
> -	};
> +	}
>  }
>  
>  static struct sbp_target_agent *sbp_target_agent_register(
Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>