lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CALAqxLWJNDDx_MFvYHszFXy=aV9bZGi50L3zDtuGaiYUbHKHSA@mail.gmail.com> Date: Tue, 2 Feb 2021 18:07:38 -0800 From: John Stultz <john.stultz@...aro.org> To: Suren Baghdasaryan <surenb@...gle.com> Cc: Sumit Semwal <sumit.semwal@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>, Christoph Hellwig <hch@...radead.org>, Liam Mark <lmark@...eaurora.org>, Laura Abbott <labbott@...hat.com>, Brian Starkey <Brian.Starkey@....com>, Christian Koenig <christian.koenig@....com>, Chris Goldsworthy <cgoldswo@...eaurora.org>, Ørjan Eide <orjan.eide@....com>, Robin Murphy <robin.murphy@....com>, James Jones <jajones@...dia.com>, Minchan Kim <minchan@...nel.org>, Hridya Valsaraju <hridya@...gle.com>, Sandeep Patil <sspatil@...gle.com>, linux-media <linux-media@...r.kernel.org>, dri-devel <dri-devel@...ts.freedesktop.org>, "moderated list:DMA BUFFER SHARING FRAMEWORK" <linaro-mm-sig@...ts.linaro.org>, linux-mm <linux-mm@...ck.org>, lkml <linux-kernel@...r.kernel.org>, Android Kernel Team <kernel-team@...roid.com> Subject: Re: [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm On Tue, Feb 2, 2021 at 4:31 PM Suren Baghdasaryan <surenb@...gle.com> wrote: > Currently system heap maps its buffers with VM_PFNMAP flag using > remap_pfn_range. This results in such buffers not being accounted > for in PSS calculations because vm treats this memory as having no > page structs. Without page structs there are no counters representing > how many processes are mapping a page and therefore PSS calculation > is impossible. > Historically, ION driver used to map its buffers as VM_PFNMAP areas > due to memory carveouts that did not have page structs [1]. That > is not the case anymore and it seems there was desire to move away > from remap_pfn_range [2]. > Dmabuf system heap design inherits this ION behavior and maps its > pages using remap_pfn_range even though allocated pages are backed > by page structs. > Replace remap_pfn_range with vm_insert_page, following Laura's suggestion > in [1]. This would allow correct PSS calculation for dmabufs. > > [1] https://driverdev-devel.linuxdriverproject.narkive.com/v0fJGpaD/using-ion-memory-for-direct-io > [2] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-October/127519.html > (sorry, could not find lore links for these discussions) > > Suggested-by: Laura Abbott <labbott@...nel.org> > Signed-off-by: Suren Baghdasaryan <surenb@...gle.com> For consistency, do we need something similar for the cma heap as well? thanks -john
Powered by blists - more mailing lists