linux-kernel - Re: [PATCH RESEND v3] virtio-input: add multi-touch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210203142239.7lknkkg4zx5kuaf2@sirius.home.kraxel.org>
Date:   Wed, 3 Feb 2021 15:22:39 +0100
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Vasyl Vavrychuk <vasyl.vavrychuk@...nsynergy.com>
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Henrik Rydberg <rydberg@...math.org>,
        Mathias Crombez <mathias.crombez@...recia.com>
Subject: Re: [PATCH RESEND v3] virtio-input: add multi-touch support

On Fri, Jan 15, 2021 at 02:26:23AM +0200, Vasyl Vavrychuk wrote:
> From: Mathias Crombez <mathias.crombez@...recia.com>
> 
> Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
> input_handle_abs_event.
> 
> Implementation is based on uinput_create_device.
> 
> Signed-off-by: Mathias Crombez <mathias.crombez@...recia.com>
> Co-developed-by: Vasyl Vavrychuk <vasyl.vavrychuk@...nsynergy.com>
> Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@...nsynergy.com>
> ---
> v2: fix patch corrupted by corporate email server
> v3: use number of slots from the host
> 
> Resend since to feedback.
> 
>  drivers/virtio/virtio_input.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Have no test hardware, the logic looks sane though.

Reviewed-by: Gerd Hoffmann <kraxel@...hat.com>

take care,
  Gerd