| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202102031003.C8FvxJV3-lkp@intel.com>
Date: Wed, 3 Feb 2021 10:23:22 +0800
From: kernel test robot <lkp@...el.com>
To: Kees Cook <keescook@...omium.org>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Memory Management List <linux-mm@...ck.org>
Subject: drivers/scsi/FlashPoint.c:1744:12: warning: stack frame size of 1552
bytes in function 'FlashPoint_HandleInterrupt'
Hi Kees,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3aaf0a27ffc29b19a62314edd684b9bc6346f9a8
commit: c637693b20da8706b7f48d96882c9c80ae935151 ubsan: remove UBSAN_MISC in favor of individual options
date: 7 weeks ago
config: powerpc-randconfig-r001-20210202 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 275c6af7d7f1ed63a03d05b4484413e447133269)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c637693b20da8706b7f48d96882c9c80ae935151
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout c637693b20da8706b7f48d96882c9c80ae935151
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from drivers/scsi/BusLogic.c:51:
>> drivers/scsi/FlashPoint.c:1744:12: warning: stack frame size of 1552 bytes in function 'FlashPoint_HandleInterrupt' [-Wframe-larger-than=]
static int FlashPoint_HandleInterrupt(void *pcard)
^
1 warning generated.
vim +/FlashPoint_HandleInterrupt +1744 drivers/scsi/FlashPoint.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1734
^1da177e4c3f41 Linus Torvalds 2005-04-16 1735 /*---------------------------------------------------------------------
^1da177e4c3f41 Linus Torvalds 2005-04-16 1736 *
d8b6b8bd8a99ee Alexey Dobriyan 2006-03-08 1737 * Function: FlashPoint_HandleInterrupt
^1da177e4c3f41 Linus Torvalds 2005-04-16 1738 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 1739 * Description: This is our entry point when an interrupt is generated
^1da177e4c3f41 Linus Torvalds 2005-04-16 1740 * by the card and the upper level driver passes it on to
^1da177e4c3f41 Linus Torvalds 2005-04-16 1741 * us.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1742 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 1743 *---------------------------------------------------------------------*/
391e2f25601e34 Khalid Aziz 2013-05-16 @1744 static int FlashPoint_HandleInterrupt(void *pcard)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1745 {
69eb2ea4779336 Alexey Dobriyan 2006-03-08 1746 struct sccb *currSCCB;
db038cf86fc63d Alexey Dobriyan 2006-03-08 1747 unsigned char thisCard, result, bm_status, bm_int_st;
c823feeb33161c Alexey Dobriyan 2006-03-08 1748 unsigned short hp_int;
db038cf86fc63d Alexey Dobriyan 2006-03-08 1749 unsigned char i, target;
391e2f25601e34 Khalid Aziz 2013-05-16 1750 struct sccb_card *pCurrCard = pcard;
391e2f25601e34 Khalid Aziz 2013-05-16 1751 u32 ioport;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1752
391e2f25601e34 Khalid Aziz 2013-05-16 1753 thisCard = pCurrCard->cardIndex;
391e2f25601e34 Khalid Aziz 2013-05-16 1754 ioport = pCurrCard->ioPort;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1755
^1da177e4c3f41 Linus Torvalds 2005-04-16 1756 MDISABLE_INT(ioport);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1757
^1da177e4c3f41 Linus Torvalds 2005-04-16 1758 if ((bm_int_st = RD_HARPOON(ioport + hp_int_status)) & EXT_STATUS_ON)
391e2f25601e34 Khalid Aziz 2013-05-16 1759 bm_status = RD_HARPOON(ioport + hp_ext_status) &
391e2f25601e34 Khalid Aziz 2013-05-16 1760 (unsigned char)BAD_EXT_STATUS;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1761 else
^1da177e4c3f41 Linus Torvalds 2005-04-16 1762 bm_status = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1763
^1da177e4c3f41 Linus Torvalds 2005-04-16 1764 WR_HARPOON(ioport + hp_int_mask, (INT_CMD_COMPL | SCSI_INTERRUPT));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1765
391e2f25601e34 Khalid Aziz 2013-05-16 1766 while ((hp_int = RDW_HARPOON((ioport + hp_intstat)) &
391e2f25601e34 Khalid Aziz 2013-05-16 1767 FPT_default_intena) | bm_status) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1768
391e2f25601e34 Khalid Aziz 2013-05-16 1769 currSCCB = pCurrCard->currentSCCB;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1770
^1da177e4c3f41 Linus Torvalds 2005-04-16 1771 if (hp_int & (FIFO | TIMEOUT | RESET | SCAM_SEL) || bm_status) {
5c04a7b8981f28 Alexey Dobriyan 2006-03-08 1772 result =
391e2f25601e34 Khalid Aziz 2013-05-16 1773 FPT_SccbMgr_bad_isr(ioport, thisCard, pCurrCard,
5c04a7b8981f28 Alexey Dobriyan 2006-03-08 1774 hp_int);
5c04a7b8981f28 Alexey Dobriyan 2006-03-08 1775 WRW_HARPOON((ioport + hp_intstat),
5c04a7b8981f28 Alexey Dobriyan 2006-03-08 1776 (FIFO | TIMEOUT | RESET | SCAM_SEL));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1777 bm_status = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1778
^1da177e4c3f41 Linus Torvalds 2005-04-16 1779 if (result) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1780
^1da177e4c3f41 Linus Torvalds 2005-04-16 1781 MENABLE_INT(ioport);
5c1b85e209af41 Alexey Dobriyan 2006-03-08 1782 return result;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1783 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1784 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1785
^1da177e4c3f41 Linus Torvalds 2005-04-16 1786 else if (hp_int & ICMD_COMP) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1787
^1da177e4c3f41 Linus Torvalds 2005-04-16 1788 if (!(hp_int & BUS_FREE)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1789 /* Wait for the BusFree before starting a new command. We
^1da177e4c3f41 Linus Torvalds 2005-04-16 1790 must also check for being reselected since the BusFree
^1da177e4c3f41 Linus Torvalds 2005-04-16 1791 may not show up if another device reselects us in 1.5us or
^1da177e4c3f41 Linus Torvalds 2005-04-16 1792 less. SRR Wednesday, 3/8/1995.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1793 */
5c04a7b8981f28 Alexey Dobriyan 2006-03-08 1794 while (!
5c04a7b8981f28 Alexey Dobriyan 2006-03-08 1795 (RDW_HARPOON((ioport + hp_intstat)) &
5c04a7b8981f28 Alexey Dobriyan 2006-03-08 1796 (BUS_FREE | RSEL))) ;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1797 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1798
391e2f25601e34 Khalid Aziz 2013-05-16 1799 if (pCurrCard->globalFlags & F_HOST_XFER_ACT)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1800
47b5d69c4aa753 James Bottomley 2005-04-24 1801 FPT_phaseChkFifo(ioport, thisCard);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1802
:::::: The code at line 1744 was first introduced by commit
:::::: 391e2f25601e34a7d7e5dc155e487bc58dffd8c6 [SCSI] BusLogic: Port driver to 64-bit.
:::::: TO: Khalid Aziz <khalid.aziz@...cle.com>
:::::: CC: James Bottomley <JBottomley@...allels.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (41283 bytes)
Powered by blists - more mailing lists