linux-kernel - Re: Kconfig-induced build errors: CONFIG_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-9b4a74fd-62d8-421f-8150-9147da7e39b2@penguin>
Date:   Tue, 02 Feb 2021 18:27:42 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     geert@...ux-m68k.org
CC:     atishp@...shpatra.org, rdunlap@...radead.org,
        linux-riscv@...ts.infradead.org, aou@...s.berkeley.edu,
        linux-kernel@...r.kernel.org,
        Paul Walmsley <paul.walmsley@...ive.com>
Subject:     Re: Kconfig-induced build errors: CONFIG_PAGE_OFFSET

On Fri, 29 Jan 2021 05:52:51 PST (-0800), geert@...ux-m68k.org wrote:
> Hi Atish,
>
> On Thu, Jan 28, 2021 at 9:09 PM Atish Patra <atishp@...shpatra.org> wrote:
>> On Wed, Jan 27, 2021 at 7:18 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>> > I took a riscv-32 .config from kernel test robot (it was for a clang build)
>> > and did a "make olddefconfig" (using gcc tools) and got build errors
>> > due to this config item from arch/riscv/Kconfig;
>> >
>> >
>> > config PAGE_OFFSET
>> >         hex
>> >         default 0xC0000000 if 32BIT && MAXPHYSMEM_1GB
>> >         default 0x80000000 if 64BIT && !MMU
>> >         default 0xffffffff80000000 if 64BIT && MAXPHYSMEM_2GB
>> >         default 0xffffffe000000000 if 64BIT && MAXPHYSMEM_128GB
>> >
>> > PAGE_OFFSET is undefined for the case of 32BIT && MAXPHYSMEM_2GB.
>>
>> Because, RV32 doesn't support 2GB physical memory yet.
>>
>> The compilation errors can be fixed by not allowing MAXPHYSMEM_2GB for RV32 and
>> MAXPHYSMEM_1GB for RV64. How about this ?
>>
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -253,8 +253,10 @@ choice
>>         default MAXPHYSMEM_128GB if 64BIT && CMODEL_MEDANY
>>
>>         config MAXPHYSMEM_1GB
>> +               depends on 32BIT
>>                 bool "1GiB"
>>         config MAXPHYSMEM_2GB
>> +               depends on 64BIT && CMODEL_MEDLOW
>>                 bool "2GiB"
>>         config MAXPHYSMEM_128GB
>>                 depends on 64BIT && CMODEL_MEDANY
>
> Thanks, works fine on litex-vexriscv.
> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Atish: did I miss an actual patch?  I just see diff here.