linux-kernel - Re: [PATCH 3/3] RISC-V: Define MAXPHYSMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-3aa36699-55e0-4f82-80f7-0d7248ac3b5c@penguin>
Date:   Tue, 02 Feb 2021 18:34:58 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     Atish Patra <Atish.Patra@....com>
CC:     linux-kernel@...r.kernel.org, Atish Patra <Atish.Patra@....com>,
        rdunlap@...radead.org, geert@...ux-m68k.org, aou@...s.berkeley.edu,
        Anup Patel <Anup.Patel@....com>, ardb@...nel.org,
        kirill.shutemov@...ux.intel.com, linux-riscv@...ts.infradead.org,
        ndesaulniers@...ogle.com, Paul Walmsley <paul.walmsley@...ive.com>,
        svancau@...il.com, zong.li@...ive.com
Subject:     Re: [PATCH 3/3] RISC-V: Define MAXPHYSMEM_1GB only for RV32

On Fri, 29 Jan 2021 11:00:38 PST (-0800), Atish Patra wrote:
> MAXPHYSMEM_1GB option was added for RV32 because RV32 only supports 1GB
> of maximum physical memory. This lead to few compilation errors reported
> by kernel test robot which created the following configuration combination
> which are not useful but can be configured.
>
> 1. MAXPHYSMEM_1GB & RV64
> 2, MAXPHYSMEM_2GB & RV32
>
> Fixes: e557793799c5 ("RISC-V: Fix maximum allowed phsyical memory for RV32")
>
> Fix this by restricting MAXPHYSMEM_1GB for RV32 and MAXPHYSMEM_2GB only for
> RV64.
>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Atish Patra <atish.patra@....com>
> ---
>  arch/riscv/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index e9e2c1f0a690..e0a34eb5ed3b 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -252,8 +252,10 @@ choice
>  	default MAXPHYSMEM_128GB if 64BIT && CMODEL_MEDANY
>
>  	config MAXPHYSMEM_1GB
> +		depends on 32BIT
>  		bool "1GiB"
>  	config MAXPHYSMEM_2GB
> +		depends on 64BIT && CMODEL_MEDLOW
>  		bool "2GiB"
>  	config MAXPHYSMEM_128GB
>  		depends on 64BIT && CMODEL_MEDANY

Ah, I guess here's the patch :).  This is on fixes.

Thanks!