linux-kernel - Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Wfg4NOCioKA4OHuaKezGgusc38YgMQ9U6Zvo7dO=zY2w@mail.gmail.com>
Date:   Wed, 3 Feb 2021 07:57:45 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Stephen Zhang <stephenzhangzsd@...il.com>
Cc:     Jason Wessel <jason.wessel@...driver.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        kgdb-bugreport@...ts.sourceforge.net,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

Hi,

On Wed, Feb 3, 2021 at 3:31 AM Stephen Zhang <stephenzhangzsd@...il.com> wrote:
>
> Doug Anderson <dianders@...omium.org> 于2021年2月3日周三 上午1:40写道：
>>
>> <tab>kdb_dbg_printf(AR, "returns [...] (%s)\n",
>> <tab><tab>       ret, symtab->sym_start, [...], symtab->sym_name);
>
>
> Thank you for the detailed explanation. In this case, Shouldn't the "ret"  be under
> the "(AR"? like below:
>
> <tab>kdb_dbg_printf(AR, "returns [...] (%s)\n",
> <tab><tab>               ret, symtab->sym_start, [...], symtab->sym_name);
>
>  See
> <https://www.kernel.org/doc/html/v5.10/process/coding-style.html#breaking-long-lines-and-strings>
> where it says "A very commonly used style is to align descendants to a function open parenthesis".
> The "descendants" here means the next line, right?

Yes, "descendants" means the next line.

I have a guess about what your problem is.  In kernel land, tabs are 8
spaces, not 4.  Also make sure your editor is using a fixed-width
font.  In gmail my example might not look like it's lining up, but
when you go into the editor it should.

-Doug