linux-kernel - Re: [PATCH v4 4/6] dm: new ioctl DM_DEV_REMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBrIuipGnzmsyKxg@kroah.com>
Date:   Wed, 3 Feb 2021 17:00:58 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sergei Shtepa <sergei.shtepa@...am.com>
Cc:     Damien.LeMoal@....com, snitzer@...hat.com, hare@...e.de,
        ming.lei@...hat.com, agk@...hat.com, corbet@....net,
        axboe@...nel.dk, jack@...e.cz, johannes.thumshirn@....com,
        koct9i@...il.com, steve@....org, dm-devel@...hat.com,
        linux-block@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, pavgel.tide@...am.com
Subject: Re: [PATCH v4 4/6] dm: new ioctl DM_DEV_REMAP_CMD

On Wed, Feb 03, 2021 at 06:53:56PM +0300, Sergei Shtepa wrote:
> --- a/include/uapi/linux/dm-ioctl.h
> +++ b/include/uapi/linux/dm-ioctl.h
> @@ -214,6 +214,15 @@ struct dm_target_msg {
>  	char message[0];
>  };
>  
> +enum {
> +	REMAP_START_CMD = 1,
> +	REMAP_FINISH_CMD,

Don't you need to say what REMAP_FINISH_CMD is explicitly?

> +};
> +
> +struct dm_remap_param {
> +	uint8_t cmd;
> +	uint8_t params[0];

These need to be __u8, "uint8_t" is not a valid type that crosses the
user/kernel boundry.

thanks,

greg k-h