linux-kernel - Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59881FC4-7621-4740-A4DE-57FAA5936CDB@oracle.com>
Date:   Wed, 3 Feb 2021 16:13:21 +0000
From:   Himanshu Madhani <himanshu.madhani@...cle.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
CC:     "njavali@...vell.com" <njavali@...vell.com>,
        "GR-QLogic-Storage-Upstream@...vell.com" 
        <GR-QLogic-Storage-Upstream@...vell.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        Martin Petersen <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables



> On Feb 2, 2021, at 8:26 PM, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:
> 
> Fix the following coccicheck warnings:
> 
> ./drivers/scsi/qla2xxx/qla_target.c:984:12-14: WARNING !A || A && B is
> equivalent to !A || B.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 0d09480..c48daf5 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -981,8 +981,7 @@ void qlt_free_session_done(struct work_struct *work)
> 			int rc;
> 
> 			if (!own ||
> -			    (own &&
> -			     (own->iocb.u.isp24.status_subcode == ELS_PLOGI))) {
> +			     (own->iocb.u.isp24.status_subcode == ELS_PLOGI)) {
> 				rc = qla2x00_post_async_logout_work(vha, sess,
> 				    NULL);
> 				if (rc != QLA_SUCCESS)
> -- 
> 1.8.3.1
> 

Looks Good. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

--
Himanshu Madhani	 Oracle Linux Engineering