linux-kernel - Re: [PATCH v3 01/11] docs: ioctl-number.rst: reserve IIO subsystem ioctl() space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210204170655.00001b03@Huawei.com>
Date:   Thu, 4 Feb 2021 17:06:55 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <lars@...afoo.de>, <Michael.Hennerich@...log.com>,
        <jic23@...nel.org>, <nuno.sa@...log.com>,
        <dragos.bogdan@...log.com>, <rafael@...nel.org>,
        <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 01/11] docs: ioctl-number.rst: reserve IIO subsystem
 ioctl() space

On Mon, 1 Feb 2021 16:50:55 +0200
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> Currently, only the 'i' 0x90 ioctl() actually exists and is defined in
> 'uapi/linux/iio/events.h'.
> 
> It's the IIO_GET_EVENT_FD_IOCTL, which is used to retrieve and FD for
> reading events from an IIO device.
> We will want to add more ioct() numbers, so with this change the 'i'
> 0x90-0x9F space is reserved for IIO ioctl() calls.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Hi Alex,

Thanks for tidying this up.  My bad from a long time ago to not register
this at the time.

> ---
>  Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index a4c75a28c839..9ebde26b7e32 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -245,6 +245,7 @@ Code  Seq#    Include File                                           Comments
>  'i'   00-3F  linux/i2o-dev.h                                         conflict!
>  'i'   0B-1F  linux/ipmi.h                                            conflict!
>  'i'   80-8F  linux/i8k.h
> +'i'   90-9F  `uapi/linux/iio/*.h`                                    IIO

I think the uapi/ bit is effectively implicit. I checked a few of them and the
definitions are in uapi/linux/

>  'j'   00-3F  linux/joystick.h
>  'k'   00-0F  linux/spi/spidev.h                                      conflict!
>  'k'   00-05  video/kyro.h                                            conflict!