linux-kernel - Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBtcy8WPPSz6wCfO@Gentoo>
Date:   Thu, 4 Feb 2021 08:02:43 +0530
From:   Bhaskar Chowdhury <unixbhaskar@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of
 spellings and get rid of blank lines too in the file ether1.c

On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote:
>On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote:
>>
>> s/initialsation/initialisation/
>> s/specifiing/specifying/
>>
>> Plus get rid of few blank lines.
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
>> ---
>> Changes from V1:
>>    Fix typo in the subject line
>>    Give explanation of all the changes in changelog text
>>
>>  drivers/net/ethernet/i825xx/ether1.c | 9 +++------
>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
>> index a0bfb509e002..850ea32091ed 100644
>> --- a/drivers/net/ethernet/i825xx/ether1.c
>> +++ b/drivers/net/ethernet/i825xx/ether1.c
>
>a. don't delete the blank lines
>b. the change below is not described and does not change any whitespace AFAICT.
>   I.e., DDT [don't do that].
>
But what do you do when things getting automatically inducted in the
patch???(You got to believe me)

I haven't had touch that bloody function with my keystroke and it gets it on
its own! Bemusing!

Those blank lines too inducted from the fresh file(means in pristine form) ,so
thought pruning would be good..hence the decision to get rid of those.

Wondering what the fuck is going on....

>> @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec)
>>  {
>>  	struct net_device *dev = ecard_get_drvdata(ec);
>>
>> -	ecard_set_drvdata(ec, NULL);
>> +	ecard_set_drvdata(ec, NULL);
>>
>>  	unregister_netdev(dev);
>>  	free_netdev(dev);
>
>
>--
>~Randy
>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)