linux-kernel - Re: [PATCH] net/qrtr: replaced useless kzalloc with kmalloc in qrtr_tun_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 10:53:56 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sabyrzhan Tasbolatov <snovitoll@...il.com>
Cc:     davem@...emloft.net, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org,
        syzbot+c2a7e5c5211605a90865@...kaller.appspotmail.com
Subject: Re: [PATCH] net/qrtr: replaced useless kzalloc with kmalloc in
 qrtr_tun_write_iter()

On Thu, 4 Feb 2021 10:51:59 -0800 Jakub Kicinski wrote:
> On Thu,  4 Feb 2021 15:02:30 +0600 Sabyrzhan Tasbolatov wrote:
> > Replaced kzalloc() with kmalloc(), there is no need for zeroed-out
> > memory for simple void *kbuf.  
> 
> There is no need for zeroed-out memory because it's immediately
> overwritten by copy_from_iter...

Also if you don't mind please wait a week until the fixes get merged
back into net-next and then repost. Otherwise this patch will not apply
cleanly. (Fixes are merged into a different tree than cleanups)

> > Signed-off-by: Sabyrzhan Tasbolatov <snovitoll@...il.com>
> > ---
> >  net/qrtr/tun.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/qrtr/tun.c b/net/qrtr/tun.c
> > index b238c40a9984..9b607c7614de 100644
> > --- a/net/qrtr/tun.c
> > +++ b/net/qrtr/tun.c
> > @@ -86,7 +86,7 @@ static ssize_t qrtr_tun_write_iter(struct kiocb *iocb, struct iov_iter *from)
> >  	if (len > KMALLOC_MAX_SIZE)
> >  		return -ENOMEM;
> >  
> > -	kbuf = kzalloc(len, GFP_KERNEL);
> > +	kbuf = kmalloc(len, GFP_KERNEL);
> >  	if (!kbuf)
> >  		return -ENOMEM;
> >    
>