linux-kernel - Re: [PATCH] drm/bridge: make a const array static, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 21:09:53 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: make a const array static, makes object
 smaller

Hi Colin,

Thank you for the patch.

On Thu, Feb 04, 2021 at 06:33:44PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the const array frs_limits on the stack but instead make
> it static. Makes the object code smaller by 128 bytes:
> 
> Before:
>    text    data     bss     dec     hex filename
>   24845    7440      64   32349    7e5d ./drivers/gpu/drm/bridge/tc358768.o
> 
> After:
>    text    data     bss     dec     hex filename
>   24749    7408      64   32221    7ddd ./drivers/gpu/drm/bridge/tc358768.o
> 
> (gcc version 10.2.0)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/bridge/tc358768.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index 8ed8302d6bbb..2495ea46b091 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -291,7 +291,7 @@ static int tc358768_calc_pll(struct tc358768_priv *priv,
>  			     const struct drm_display_mode *mode,
>  			     bool verify_only)
>  {
> -	const u32 frs_limits[] = {
> +	static const u32 frs_limits[] = {
>  		1000000000,
>  		500000000,
>  		250000000,

-- 
Regards,

Laurent Pinchart