linux-kernel - Re: [PATCH v4 5/5] mips: dts: Add support for Cisco SG220-26 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210204205913.GB19460@alpha.franken.de>
Date:   Thu, 4 Feb 2021 21:59:13 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Bert Vermeulen <bert@...t.com>
Cc:     Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sander Vanheule <sander@...nheule.net>,
        John Crispin <john@...ozen.org>,
        Birger Koblitz <mail@...ger-koblitz.de>
Subject: Re: [PATCH v4 5/5] mips: dts: Add support for Cisco SG220-26 switch

On Tue, Jan 19, 2021 at 10:21:09AM +0100, Bert Vermeulen wrote:
> Signed-off-by: Bert Vermeulen <bert@...t.com>
> ---
>  arch/mips/Kconfig                             | 10 ++++++++
>  arch/mips/boot/dts/realtek/Makefile           |  2 ++
>  arch/mips/boot/dts/realtek/cisco_sg220-26.dts | 25 +++++++++++++++++++
>  3 files changed, 37 insertions(+)
>  create mode 100644 arch/mips/boot/dts/realtek/Makefile
>  create mode 100644 arch/mips/boot/dts/realtek/cisco_sg220-26.dts
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 0986d0c4405f..a398416842ca 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1055,6 +1055,16 @@ config NLM_XLP_BOARD
>  
>  endchoice
>  
> +if MACH_REALTEK_RTL
> +choice
> +	prompt "Realtek RTL838x/RTL839x-based switch"
> +	optional
> +
> +	config DT_CISCO_SG220_26
> +		bool "Cisco SG220-26"
> +endchoice
> +endif
> +

I've dropped that while applying, because it's just one DT so far and if
there are more of them, please move to arch/mips/realtek/Kconfig

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]