linux-kernel - Re: [PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBxsCPEFe0lxhDMO@rocinante>
Date:   Thu, 4 Feb 2021 22:50:00 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Xiaofei Tan <tanxiaofei@...wei.com>
Cc:     helgaas@...nel.org, sathyanarayanan.kuppuswamy@...ux.intel.com,
        sean.v.kelley@...el.com, Jonathan.Cameron@...wei.com,
        refactormyself@...il.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is_native()
 in some places

Hi Tan,

This is very nice!  Thank you for this.

[...]
>  	if (dev->aer_cap && pci_aer_available() &&
> -	    (pcie_ports_native || host->native_aer)) {
> +	    pcie_aer_is_native(dev)) {
>  		services |= PCIE_PORT_SERVICE_AER;
[...]

A suggestion.  You could improve this even further, for example:

  if (pci_aer_available() && pcie_aer_is_native(dev)) {

This is because the pcie_aer_is_native() function performs the
dev->aer_cap check internally, so we could rely on it, and avoid
checking the same thing twice.

What do you think?

Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

Krzysztof