linux-kernel - Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210204222425.5vlulgaip7stal3z@intel.com>
Date:   Thu, 4 Feb 2021 14:24:25 -0800
From:   Ben Widawsky <ben.widawsky@...el.com>
To:     "John Groves (jgroves)" <jgroves@...ron.com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Chris Browy <cbrowy@...ry-design.com>,
        Christoph Hellwig <hch@...radead.org>,
        Ira Weiny <ira.weiny@...el.com>,
        Jon Masters <jcm@...masters.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Rafael Wysocki <rafael.j.wysocki@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Vishal Verma <vishal.l.verma@...el.com>,
        "daniel.lll@...baba-inc.com" <daniel.lll@...baba-inc.com>,
        "Kelley, Sean V" <sean.v.kelley@...el.com>,
        David Rientjes <rientjes@...gle.com>
Subject: Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox

On 21-02-04 21:53:29, John Groves (jgroves) wrote:
>    Micron Confidential
> 
> 
> 
>    From: Dan Williams <dan.j.williams@...el.com>
>    Date: Monday, February 1, 2021 at 1:28 PM
>    To: Ben Widawsky <ben.widawsky@...el.com>
>    Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
>    linux-cxl@...r.kernel.org <linux-cxl@...r.kernel.org>, Linux ACPI
>    <linux-acpi@...r.kernel.org>, Linux Kernel Mailing List
>    <linux-kernel@...r.kernel.org>, linux-nvdimm
>    <linux-nvdimm@...ts.01.org>, Linux PCI <linux-pci@...r.kernel.org>,
>    Bjorn Helgaas <helgaas@...nel.org>, Chris Browy
>    <cbrowy@...ry-design.com>, Christoph Hellwig <hch@...radead.org>, Ira
>    Weiny <ira.weiny@...el.com>, Jon Masters <jcm@...masters.org>, Jonathan
>    Cameron <Jonathan.Cameron@...wei.com>, Rafael Wysocki
>    <rafael.j.wysocki@...el.com>, Randy Dunlap <rdunlap@...radead.org>,
>    Vishal Verma <vishal.l.verma@...el.com>, daniel.lll@...baba-inc.com
>    <daniel.lll@...baba-inc.com>, John Groves (jgroves)
>    <jgroves@...ron.com>, Kelley, Sean V <sean.v.kelley@...el.com>
>    Subject: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox
> 
>    CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless
>    you recognize the sender and were expecting this message.
>    On Mon, Feb 1, 2021 at 11:13 AM Ben Widawsky <ben.widawsky@...el.com>
>    wrote:
>    >
>    > On 21-02-01 12:54:00, Konrad Rzeszutek Wilk wrote:
>    > > > +#define
>    cxl_doorbell_busy(cxlm)
>    \
>    > > > +   (cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CTRL_OFFSET)
>    &                    \
>    > > > +    CXLDEV_MB_CTRL_DOORBELL)
>    > > > +
>    > > > +#define CXL_MAILBOX_TIMEOUT_US 2000
>    > >
>    > > You been using the spec for the values. Is that number also from it
>    ?
>    > >
>    >
>    > Yes it is. I'll add a comment with the spec reference.
> 
> 
> 
>    From section 8.2.8.4 in the CXL 2.0 spec: “The mailbox command timeout
>    is 2 seconds.”  So this should be:
> 
> 
>    #define CXL_MAILBOX_TIMEOUT_US 2000000
> 
> 
>    …right? 2000us is 2ms…
> 
> 

Thanks. This was caught already in earlier review by David Rientjes
<rientjes@...gle.com>

It's renamed CXL_MAILBOX_TIMEOUT_MS 2000