linux-kernel - Re: [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJF2gTTmBUjrTVmQ+CqGtYtBkLO6C5WguWsT7+rFLOp4n=9diA@mail.gmail.com>
Date:   Thu, 4 Feb 2021 12:32:31 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-csky@...r.kernel.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610

Thx Marc,

On Wed, Feb 3, 2021 at 11:44 PM Marc Zyngier <maz@...nel.org> wrote:
>
> On 2021-02-03 13:48, guoren@...nel.org wrote:
> > From: Guo Ren <guoren@...ux.alibaba.com>
> >
> > The irq-csky-mpintc.c only could support CPU_CK860 and it will
> > compile error with CPU_CK610.
> >
> > Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> > Cc: Marc Zyngier <maz@...nel.org>
> > ---
> >  drivers/irqchip/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index b147f22a78f4..9be2dd5c6380 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -433,7 +433,7 @@ config QCOM_PDC
> >
> >  config CSKY_MPINTC
> >       bool "C-SKY Multi Processor Interrupt Controller"
> > -     depends on CSKY
> > +     depends on CSKY && CPU_CK860
> >       help
> >         Say yes here to enable C-SKY SMP interrupt controller driver used
> >         for C-SKY SMP system.
>
> I'm not convinced this is the right fix.
>
> You already select CSKY_MPINTC only when CPU_CK860 is selected,
> so preventing the user from selecting it should simply be a matter
> of dropping the string after bool.
Yes, you are right. I will change it into arch/csky.


-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/