linux-kernel - Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210204054124.GB7229@gondor.apana.org.au>
Date:   Thu, 4 Feb 2021 16:41:24 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Saulo Alessandre <saulo.alessandre@...il.com>,
        Stefan Berger <stefanb@...ux.ibm.com>
Cc:     ardb@...nel.org, daniele.alessandrelli@...ux.intel.com,
        davem@...emloft.net, elena.reshetova@...el.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        mgross@...ux.intel.com, prabhjot.khurana@...el.com,
        wangzhou1@...ilicon.com, xuzaibo@...wei.com, yumeng18@...wei.com
Subject: Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

On Wed, Feb 03, 2021 at 03:03:44PM -0300, Saulo Alessandre wrote:
>
> In this patch I'm using akcipher allocate like ecdsa(sha1,sha256,...), 
> because the ecdsa algo is generic, and using the curve name and ndigits
> inside vli_mmod_fast to discover the curve, but I agree the correct way
> would be allocate ecdsa-nist-p521(sha1,...) and have all params for the
> curve inside strut ecc_curve, remembering that we have anothers curves 
> incoming, like Edwards.

I'm not sure whether we really should encode hash into the algorithm
name.  This may be something that we can move into setkey instead.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt