linux-kernel - Re: [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YBuSnPDbrXcnBcgZ@kroah.com>
Date:   Thu, 4 Feb 2021 07:22:20 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ye Bin <yebin10@...wei.com>
Cc:     heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] usb: typec: remove unused variable ‘ret’ in
 typec_partner_set_pd_revision

On Thu, Feb 04, 2021 at 09:24:30AM +0800, Ye Bin wrote:
> Fix follow warning:
> drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ [-Wunused-variable]
>   int ret;
>       ^~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ye Bin <yebin10@...wei.com>
> ---
>  drivers/usb/typec/class.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index b6ceab3dc16b..1c2d50e016e2 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -760,8 +760,6 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
>   */
>  int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)
>  {
> -	int ret;
> -
>  	if (partner->pd_revision == pd_revision)
>  		return 0;
>  

This is already fixed in my tree, right?  What did you make this
against?

thanks,

greg k-h