linux-kernel - Re: [PATCH] add chan->cl check in mbox_chan_received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+kUaCeJ_o4kdEtYP4MaDs7X87tCQK5UxQDj5f8EqGqxTPkvQg@mail.gmail.com>
Date:   Thu, 4 Feb 2021 15:22:07 +0800
From:   Yao Haidong <yaohaidong369@...il.com>
To:     Jassi Brar <jassisinghbrar@...il.com>
Cc:     natechancellor@...il.com,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        clang-built-linux@...glegroups.com,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH] add chan->cl check in mbox_chan_received_data()

 Oh, I see, thank you

2021-02-01 14:28 GMT+08:00, Jassi Brar <jassisinghbrar@...il.com>:
> On Thu, Jan 7, 2021 at 5:53 AM haidong yao <yaohaidong369@...il.com> wrote:
>>
>> Hi Jassi Brar
>>
>> Thank you very much for your reply.
>>
>> Look at the function sprd_mbox_outbox_isr .
>>
>> Chan is !NULL.
>>
>> chan->cl is NULL when the client driver not loaded, the controller
>> driver don't know the client driver loaded successfully, so, I do not
>> use mbox_free_channel.
>>
>> Here,How do you know chan->cl is ok?
>>
> The channel is supposed to get/send data _only_ if it is being used by a
> client.
> Which you can mark in .startup() and .shutdown().
>
> Checking for chan->cl will make your symptoms disappear but that is
> not the right fix for the issue.
> The right fix is to EITHER not cause Rx/Tx interrupt on a channel not
> being used, OR not send it to upper layers.
>
> thanks.
>