linux-kernel - Re: [PATCH -next] KVM: s390: Return the correct errno code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210204093227.3f088c8a.cohuck@redhat.com>
Date:   Thu, 4 Feb 2021 09:32:27 +0100
From:   Cornelia Huck <cohuck@...hat.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     <kvm@...r.kernel.org>, <linux-s390@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <borntraeger@...ibm.com>,
        <frankja@...ux.ibm.com>, <david@...hat.com>,
        <imbrenda@...ux.ibm.com>, <hca@...ux.ibm.com>, <gor@...ux.ibm.com>
Subject: Re: [PATCH -next] KVM: s390: Return the correct errno code

On Thu, 4 Feb 2021 16:05:23 +0800
Zheng Yongjun <zhengyongjun3@...wei.com> wrote:

> When valloc failed, should return ENOMEM rather than ENOBUF.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  arch/s390/kvm/interrupt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 2f177298c663..6b7acc27cfa2 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -2252,7 +2252,7 @@ static int get_all_floating_irqs(struct kvm *kvm, u8 __user *usrbuf, u64 len)
>  	 */
>  	buf = vzalloc(len);
>  	if (!buf)
> -		return -ENOBUFS;
> +		return -ENOMEM;
>  
>  	max_irqs = len / sizeof(struct kvm_s390_irq);
>  

This breaks a user space interface (see the comment right above the
vzalloc).