linux-kernel - Re: [PATCH -next] RISCV: Add some depends for NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80f2821a-1c08-ce16-b7a9-7d2debc7f16e@huawei.com>
Date:   Thu, 4 Feb 2021 17:17:34 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Atish Patra <atishp@...shpatra.org>
CC:     Palmer Dabbelt <palmer@...belt.com>,
        Atish Patra <atish.patra@....com>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        Palmer Dabbelt <palmerdabbelt@...gle.com>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>
Subject: Re: [PATCH -next] RISCV: Add some depends for NUMA


On 2021/2/4 3:59, Atish Patra wrote:
> On Wed, Feb 3, 2021 at 6:20 AM Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
>> The numa feature is useless for riscv32 platform(MAXPHYSMEM_1GB if 32bit),
>> and it should depends on SMP feature, this also fix the build error,
>>
>>    riscv64-buildroot-linux-gnu-ld: mm/page_alloc.o: in function `.L0 ':
>>    page_alloc.c:(.text+0x4808): undefined reference to `node_reclaim_distance'
>>
> Thanks for the fix. The commit text is a bit ambiguous. The
> compilation issue error is due to SMP.
> RV32 dependency is just another fix  as NUMA is not very useful for RV32.

Yes, the two depends fix different issue，the lack of SMP leads to the 
compilation issue,  another

depend is to remove support on RV32.

Thanks for your review, if necessary, I could resend with changelog 
updated.

> Reviewed-by: Atish Patra <atish.patra@....com>