linux-kernel - Re: [PATCH] scsi: ipr: Remove unneeded return variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN4PR0401MB35981D9E1825962920A0CB6E9BB39@SN4PR0401MB3598.namprd04.prod.outlook.com>
Date:   Thu, 4 Feb 2021 09:33:06 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "brking@...ibm.com" <brking@...ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ipr: Remove unneeded return variable

On 04/02/2021 08:28, Yang Li wrote:
> This patch removes unneeded return variables, using only
> '0' instead.
> It fixes the following warning detected by coccinelle:
> ./drivers/scsi/ipr.c:9508:5-7: Unneeded variable: "rc". Return "0" on
> line 9524
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/scsi/ipr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
> index e451102..8eced7c 100644
> --- a/drivers/scsi/ipr.c
> +++ b/drivers/scsi/ipr.c
> @@ -9505,7 +9505,6 @@ static pci_ers_result_t ipr_pci_error_detected(struct pci_dev *pdev,
>   **/
>  static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg)
>  {
> -	int rc = 0;
>  	unsigned long host_lock_flags = 0;
>  
>  	ENTER;
> @@ -9521,7 +9520,7 @@ static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg)
>  	spin_unlock_irqrestore(ioa_cfg->host->host_lock, host_lock_flags);
>  
>  	LEAVE;
> -	return rc;
> +	return 0;
>  }
>  
>  /**
> 

As it's always returning 0 this is dead code as well:

	rc = ipr_probe_ioa_part2(ioa_cfg);

	if (rc) {
		__ipr_remove(pdev);
		return rc;
	}

I think:
- static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg)
+ static void ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg)

is the right thing to do if you really want to touch it.