linux-kernel - [PATCH 08/20] crypto: ux500: cryp: Demote some conformant non-kernel headers fix another

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210204111000.2800436-9-lee.jones@linaro.org>
Date:   Thu,  4 Feb 2021 11:09:48 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Shujuan Chen <shujuan.chen@...ricsson.com>,
        Jonas Linde <jonas.linde@...ricsson.com>,
        Niklas Hernaeus <niklas.hernaeus@...ricsson.com>,
        Joakim Bech <joakim.xx.bech@...ricsson.com>,
        Berne Hebark <berne.herbark@...ricsson.com>,
        linux-crypto@...r.kernel.org
Subject: [PATCH 08/20] crypto: ux500: cryp: Demote some conformant non-kernel headers fix another

Fixes the following W=1 kernel build warning(s):

 drivers/crypto/ux500/cryp/cryp.c:19: warning: Incorrect use of kernel-doc format:  * cryp_wait_until_done - wait until the device logic is not busy
 drivers/crypto/ux500/cryp/cryp.c:22: warning: Function parameter or member 'device_data' not described in 'cryp_wait_until_done'
 drivers/crypto/ux500/cryp/cryp.c:22: warning: expecting prototype for ST(). Prototype was for cryp_wait_until_done() instead
 drivers/crypto/ux500/cryp/cryp.c:292: warning: Function parameter or member 'cryp_mode' not described in 'cryp_save_device_context'

Cc: Herbert Xu <herbert@...dor.apana.org.au>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Shujuan Chen <shujuan.chen@...ricsson.com>
Cc: Jonas Linde <jonas.linde@...ricsson.com>
Cc: Niklas Hernaeus <niklas.hernaeus@...ricsson.com>
Cc: Joakim Bech <joakim.xx.bech@...ricsson.com>
Cc: Berne Hebark <berne.herbark@...ricsson.com>
Cc: linux-crypto@...r.kernel.org
Signed-off-by: Lee Jones <lee.jones@...aro.org>
---
 drivers/crypto/ux500/cryp/cryp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ux500/cryp/cryp.c b/drivers/crypto/ux500/cryp/cryp.c
index 9866c2a5e9a70..759d0d9786fd1 100644
--- a/drivers/crypto/ux500/cryp/cryp.c
+++ b/drivers/crypto/ux500/cryp/cryp.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  * Copyright (C) ST-Ericsson SA 2010
  * Author: Shujuan Chen <shujuan.chen@...ricsson.com> for ST-Ericsson.
  * Author: Jonas Linde <jonas.linde@...ricsson.com> for ST-Ericsson.
@@ -15,7 +15,7 @@
 #include "cryp_p.h"
 #include "cryp.h"
 
-/**
+/*
  * cryp_wait_until_done - wait until the device logic is not busy
  */
 void cryp_wait_until_done(struct cryp_device_data *device_data)
@@ -285,6 +285,7 @@ int cryp_configure_init_vector(struct cryp_device_data *device_data,
  *				other device context parameter
  * @device_data: Pointer to the device data struct for base address.
  * @ctx: Crypto device context
+ * @cryp_mode: Mode: Polling, Interrupt or DMA
  */
 void cryp_save_device_context(struct cryp_device_data *device_data,
 			      struct cryp_device_context *ctx,
-- 
2.25.1