linux-kernel - Re: [PATCH] drm/bridge/analogix: remove redundant when devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG3jFyvfccea-5cDJ5QruTFSCobYogRQgUTTnn--6s2uFQX0NA@mail.gmail.com>
Date:   Thu, 4 Feb 2021 13:11:46 +0100
From:   Robert Foss <robert.foss@...aro.org>
To:     Bernard Zhao <bernard@...o.com>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Sam Ravnborg <sam@...nborg.org>,
        Andy Yan <andy.yan@...k-chips.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Joe Perches <joe@...ches.com>, dri-devel@...ts.freedesktop.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com
Subject: Re: [PATCH] drm/bridge/analogix: remove redundant when devm_kzalloc failed

Hey Bernard,

Thanks for the patch.

With the below fixed, feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@...aro.org>

On Tue, 2 Feb 2021 at 13:09, Bernard Zhao <bernard@...o.com> wrote:
>
> Line 1590 DRM_ERROR is redundant because devm_kzalloc() already
> prints an error.

The line number will not be so helpful for reading this commit message
in the future, so remove it and maybe just refer to DRM_ERROR being
removed.

>
> Signed-off-by: Bernard Zhao <bernard@...o.com>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index aa1bb86293fd..8f6258eb9960 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1586,10 +1586,8 @@ static int analogix_dp_create_bridge(struct drm_device *drm_dev,
>         int ret;
>
>         bridge = devm_kzalloc(drm_dev->dev, sizeof(*bridge), GFP_KERNEL);
> -       if (!bridge) {
> -               DRM_ERROR("failed to allocate for drm bridge\n");
> +       if (!bridge)
>                 return -ENOMEM;
> -       }
>
>         dp->bridge = bridge;
>
> --
> 2.29.0
>