linux-kernel - Re: [PATCH] clk: at91: Fix the declaration of the clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a9e6113-3281-04c8-00e2-c5286d8b0b01@microchip.com>
Date:   Thu, 4 Feb 2021 12:46:43 +0000
From:   <Eugen.Hristev@...rochip.com>
To:     <saravanak@...gle.com>, <Tudor.Ambarus@...rochip.com>
CC:     <alexandre.belloni@...tlin.com>, <a.fatoum@...gutronix.de>,
        <linux-kernel@...r.kernel.org>, <sboyd@...nel.org>,
        <gregkh@...uxfoundation.org>, <mturquette@...libre.com>,
        <linux-clk@...r.kernel.org>, <krzk@...nel.org>,
        <mirq-linux@...e.qmqm.pl>, <Ludovic.Desroches@...rochip.com>,
        <geert@...ux-m68k.org>, <Codrin.Ciubotariu@...rochip.com>,
        <Claudiu.Beznea@...rochip.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

On 03.02.2021 20:15, Saravana Kannan wrote:
> On Wed, Feb 3, 2021 at 7:43 AM Tudor Ambarus
> <tudor.ambarus@...rochip.com> wrote:
>>
>> These are all "early clocks" that require initialization just at
>> of_clk_init() time. Use CLK_OF_DECLARE() to declare them.
>>
>> This also fixes a problem that was spotted when fw_devlink was
>> set to 'on' by default: the boards failed to boot. The reason is
>> that CLK_OF_DECLARE_DRIVER() clears the OF_POPULATED and causes
>> the consumers of the clock to be postponed by fw_devlink until
>> the second initialization routine of the clock has been completed.
>> One of the consumers of the clock is the timer, which is used as a
>> clocksource, and needs the clock initialized early. Postponing the
>> timers caused the fail at boot.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
> 
> Thanks Tudor!
> Acked-by: Saravana Kannan <saravanak@...gle.com>
> 
> -Saravana
> 
>> ---
>> Tested on sama5d2_xplained.
>>

For sama5d3_xplained, sama5d4_xplained,
Tested-by: Eugen Hristev <eugen.hristev@...rochip.com>