linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 15:16:24 +0100
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Amit Pundir <amit.pundir@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        John Stultz <john.stultz@...aro.org>,
        Sumit Semwal <sumit.semwal@...aro.org>
Cc:     linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dt <devicetree@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, phone-devel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and
 panel bits

Hi!

>vreg_l14a_1p88: ldo14 {
>+			regulator-min-microvolt = <1800000>;
>+			regulator-max-microvolt = <1800000>;

Should probably be renamed to vreg_l14a_1p8 then.


>+	ports {
>+		port@1 {
>+			endpoint {
>+				remote-endpoint = <&tianma_nt36672a_in_0>;
>+				data-lanes = <0 1 2 3>;
>+			};
>+		};
>+	};

The endpoint has a label, you can simply use &dsi0_out {};.

>+		vddpos-supply = <&lab>;
>+		vddneg-supply = <&ibb>;

With Angelo's latest series [1] merged in, I reckon you should explicitly configure lab/ibb (like in [2]),
as wrong settings (which CAN BE SET BY THE BOOTLOADER in some instances!!) can lead to hardware damage.



Konrad

[1] https://lore.kernel.org/linux-arm-msm/20210119174421.226541-1-angelogioacchino.delregno@somainline.org/
[2] https://github.com/SoMainline/linux/commit/4f4853b2e252b5f9d03e90119110aac80258fc53