linux-kernel - Re: [PATCH] certs: include prototype for load_certificate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 16:54:01 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Eric Snowberg <eric.snowberg@...cle.com>
Cc:     dhowells@...hat.com, dwmw2@...radead.org, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] certs: include prototype for load_certificate_list

On Wed, Feb 03, 2021 at 10:32:08PM -0500, Eric Snowberg wrote:
> The build test robot reports the following when building
> with -Wmissing-prototypes
> 
>   int load_certificate_list(const u8 cert_list[],
>       ^
>   certs/common.c:6:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>   int load_certificate_list(const u8 cert_list[],
>   ^
>  static
>   1 warning generated.
> 
> Fix the warning by including the header file.
> 
> Signed-off-by: Eric Snowberg <eric.snowberg@...cle.com>
> Reported-by: kernel test robot <lkp@...el.com>


Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

BTW, should the bot have reported-by tagged?

/Jarkko

> ---
>  certs/common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/certs/common.c b/certs/common.c
> index 83800f51a1a1..16a220887a53 100644
> --- a/certs/common.c
> +++ b/certs/common.c
> @@ -2,6 +2,7 @@
>  
>  #include <linux/kernel.h>
>  #include <linux/key.h>
> +#include "common.h"
>  
>  int load_certificate_list(const u8 cert_list[],
>  			  const unsigned long list_size,
> -- 
> 2.18.4
> 
>