linux-kernel - Re: [PATCH v7 1/4] crypto: Add support for ECDSA signature verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 16:58:23 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Stefan Berger <stefanb@...ux.ibm.com>,
        Saulo Alessandre <saulo.alessandre@...il.com>,
        keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, dhowells@...hat.com, zohar@...ux.ibm.com,
        linux-kernel@...r.kernel.org, patrick@...terwijk.org,
        linux-integrity@...r.kernel.org
Subject: Re: [PATCH v7 1/4] crypto: Add support for ECDSA signature
 verification

On Thu, Feb 04, 2021 at 04:27:39PM +1100, Herbert Xu wrote:
> On Mon, Feb 01, 2021 at 10:19:07AM -0500, Stefan Berger wrote:
> > Add support for parsing the parameters of a NIST P256 or NIST P192 key.
> > Enable signature verification using these keys. The new module is
> > enabled with CONFIG_ECDSA:
> >   Elliptic Curve Digital Signature Algorithm (NIST P192, P256 etc.)
> >   is A NIST cryptographic standard algorithm. Only signature verification
> >   is implemented.
> > 
> > Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: linux-crypto@...r.kernel.org
> > ---
> >  crypto/Kconfig               |  10 +
> >  crypto/Makefile              |   6 +
> >  crypto/ecc.c                 |  13 +-
> >  crypto/ecc.h                 |  28 +++
> >  crypto/ecdsa.c               | 361 +++++++++++++++++++++++++++++++++++
> >  crypto/ecdsasignature.asn1   |   4 +
> >  crypto/testmgr.c             |  12 ++
> >  crypto/testmgr.h             | 267 ++++++++++++++++++++++++++
> >  include/linux/oid_registry.h |   4 +
> >  9 files changed, 694 insertions(+), 11 deletions(-)
> >  create mode 100644 crypto/ecdsa.c
> >  create mode 100644 crypto/ecdsasignature.asn1


Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

Great, ECDSA has been lacking for a way too long. Just wanted to
acknowledge support for this, I just now also skimmed the change
from patchwrok (way too quickly for reviewed-by but well enough
for ack).

/Jarkko