linux-kernel - Re: [PATCH] drivers: soc: atmel: fix type for same7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210204155218.GB3940495@piout.net>
Date:   Thu, 4 Feb 2021 16:52:18 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Arnd Bergmann <arnd@...db.de>,
        Sudeep Holla <sudeep.holla@....com>,
        Kai Stuhlemmer <kai.stuhlemmer@...e.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: soc: atmel: fix type for same7

On 04/02/2021 16:49:25+0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A missing comma caused a build failure:
> 
> drivers/soc/atmel/soc.c:196:24: error: too few arguments provided to function-like macro invocation
> 
> Fixes: af3a10513cd6 ("drivers: soc: atmel: add per soc id and version match masks")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

> ---
> It is broken in the soc tree at the moment, I can pick up
> the fix directly if I get an Ack
> ---
>  drivers/soc/atmel/soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index a2967846809f..a490ad7e090f 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -191,7 +191,7 @@ static const struct at91_soc socs[] __initconst = {
>  	AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>  		 AT91_CIDR_VERSION_MASK, SAME70Q20_EXID_MATCH,
>  		 "same70q20", "same7"),
> -	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK
> +	AT91_SOC(SAME70Q19_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
>  		 AT91_CIDR_VERSION_MASK, SAME70Q19_EXID_MATCH,
>  		 "same70q19", "same7"),
>  	AT91_SOC(SAMS70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> -- 
> 2.29.2
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com