linux-kernel - Re: [PATCH 04/24] perf daemon: Add server socket support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210204155324.GC910119@kernel.org>
Date:   Thu, 4 Feb 2021 12:53:24 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexei Budankov <abudankov@...wei.com>
Subject: Re: [PATCH 04/24] perf daemon: Add server socket support

Em Thu, Feb 04, 2021 at 03:49:36PM +0100, Jiri Olsa escreveu:
> On Wed, Feb 03, 2021 at 06:04:23PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sun, Jan 31, 2021 at 12:48:36AM +0100, Jiri Olsa escreveu:
> > > +static int setup_server_socket(struct daemon *daemon)
> > > +{
> > > +	struct sockaddr_un addr;
> > > +	char path[100];
> > > +	int fd;
> > > +
> > > +	fd = socket(AF_UNIX, SOCK_STREAM, 0);
> > 
> > Minor, combine decl with use, since line isn't long and its one after
> > the other, i.e.:
> > 
> > 	int fd = socket(AF_UNIX, SOCK_STREAM, 0);
> 
> hum, sure, but I'm missing the point.. I think it's less readable

one line instead of three :-)
 
> > 
> > > +	if (fd < 0) {
> > > +		fprintf(stderr, "socket: %s\n", strerror(errno));
> > > +		return -1;

- Arnaldo