linux-kernel - Re: [PATCH] misc: pvpanic: sysfs_emit uses should have a newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acfc960d-4380-de0f-5c09-fd9bcf802e0a@bytedance.com>
Date:   Thu, 4 Feb 2021 09:58:35 +0800
From:   zhenwei pi <pizhenwei@...edance.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc: pvpanic: sysfs_emit uses should have a newline

On 2/3/21 10:57 PM, Greg Kroah-Hartman wrote:
> On Mon, Feb 01, 2021 at 09:56:57AM +0800, zhenwei pi wrote:
>> On 1/30/21 3:08 AM, Joe Perches wrote:
>>> Add newline terminations to the sysfs_emit uses added by -next
>>> commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
>>>
>>> Signed-off-by: Joe Perches <joe@...ches.com>
>>> ---
>>>    drivers/misc/pvpanic.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
>>> index b1e4922a7fda..9f350e05ef68 100644
>>> --- a/drivers/misc/pvpanic.c
>>> +++ b/drivers/misc/pvpanic.c
>>> @@ -25,13 +25,13 @@ static unsigned int events;
>>>    static ssize_t capability_show(struct device *dev,
>>>    			       struct device_attribute *attr, char *buf)
>>>    {
>>> -	return sysfs_emit(buf, "%x", capability);
>>> +	return sysfs_emit(buf, "%x\n", capability);
>>>    }
>>>    static DEVICE_ATTR_RO(capability);
>>>    static ssize_t events_show(struct device *dev,  struct device_attribute *attr, char *buf)
>>>    {
>>> -	return sysfs_emit(buf, "%x", events);
>>> +	return sysfs_emit(buf, "%x\n", events);
>>>    }
>>>    static ssize_t events_store(struct device *dev,  struct device_attribute *attr,
>>>
>>>
>>
>> Hi, Greg is the maintainer of this driver.
> 
> No I am not:
> $ ./scripts/get_maintainer.pl drivers/misc/pvpanic.c
> Arnd Bergmann <arnd@...db.de> (supporter:CHAR and MISC DRIVERS)
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> (supporter:CHAR and MISC DRIVERS)
> linux-kernel@...r.kernel.org (open list)
> 
> As the developer of this driver, it would be great if you
> could review the change and provide a "Signed-off-by" line that I can
> use to accept this patch.
> 
> thanks,
> 
> greg k-h
> 

Commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue") 
is not merged into upstream currently, so this change should not affect 
the up layer users. It looks good to me.

Signed-off-by: zhenwei pi <pizhenwei@...edance.com>

-- 
zhenwei pi