linux-kernel - RE: [PATCH 10/10] clocksource/drivers/hyper-v: Move handling of STIMER0 interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR21MB15932869426E26130324DFEED7B39@MWHPR21MB1593.namprd21.prod.outlook.com>
Date:   Thu, 4 Feb 2021 16:30:18 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Wei Liu <wei.liu@...nel.org>
CC:     Stephen Hemminger <sthemmin@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>
Subject: RE: [PATCH 10/10] clocksource/drivers/hyper-v: Move handling of
 STIMER0 interrupts

From: Wei Liu <wei.liu@...nel.org> Sent: Monday, February 1, 2021 11:53 AM
> 
> On Wed, Jan 27, 2021 at 12:23:45PM -0800, Michael Kelley wrote:
> [...]
> > +static int hv_setup_stimer0_irq(void)
> > +{
> > +	int ret;
> > +
> > +	ret = acpi_register_gsi(NULL, HYPERV_STIMER0_VECTOR,
> > +			ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_HIGH);
> 
> When IO-APIC is enabled on x86, acpi_register_gsi calls
> mp_map_gsi_to_irq. That function then calls mp_find_ioapic. Is
> HYPERV_STIMER0_VECTOR, when used as a GSI, associated with an IO-APIC?
> If not, wouldn't mp_find_ioapic return an error causing
> acpi_register_gsi to fail?
> 
> Ah, it appears that this function is not called on x86. I haven't
> checked how ARM handles GSI, but presumably this works for you.  It
> would be good if a comment can be added to clarify things.
> 
> Wei.

Will do.

Michael