lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri,  5 Feb 2021 11:54:03 -0500
From:   Peter Xu <>
Cc:     Gal Pressman <>,
        Andrea Arcangeli <>,
        Christoph Hellwig <>,
        Miaohe Lin <>,
        Kirill Shutemov <>,
        Jann Horn <>,
        Matthew Wilcox <>, Jan Kara <>,
        Jason Gunthorpe <>,
        Linus Torvalds <>,
        Mike Rapoport <>,
        David Gibson <>,
        Mike Kravetz <>,,
        Kirill Tkhai <>,
        Wei Zhang <>,
        Andrew Morton <>
Subject: [PATCH v3 2/5] hugetlg: Break earlier in add_reservation_in_range() when we can

All the regions maintained in hugetlb reserved map is inclusive on "from" but
exclusive on "to".  We can break earlier even if rg->from==t because it already
means no possible intersection.

This does not need a Fixes in all cases because when it happens (rg->from==t)
we'll not break out of the loop while we should, however the next thing we'd do
is still add the last file_region we'd need and quit the loop in the next
round.  So this change is not a bugfix (since the old code should still run
okay iiuc), but we'd better still touch it up to make it logically sane.

Reviewed-by: Mike Kravetz <>
Reviewed-by: Miaohe Lin <>
Signed-off-by: Peter Xu <>
 mm/hugetlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index ec8e29c805fe..71ccec5c3817 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -387,7 +387,7 @@ static long add_reservation_in_range(struct resv_map *resv, long f, long t,
 		/* When we find a region that starts beyond our range, we've
 		 * finished.
-		if (rg->from > t)
+		if (rg->from >= t)
 		/* Add an entry for last_accounted_offset -> rg->from, and

Powered by blists - more mailing lists