linux-kernel - Re: [PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 14:35:36 +0000
From:   "Alessandrelli, Daniele" <daniele.alessandrelli@...el.com>
To:     "lee.jones@...aro.org" <lee.jones@...aro.org>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "Murphy, Declan" <declan.murphy@...el.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named
 functions/structs

On Thu, 2021-02-04 at 18:55 +0000, Lee Jones wrote:
> On Thu, 04 Feb 2021, Alessandrelli, Daniele wrote:
> 
> > On Thu, 2021-02-04 at 11:09 +0000, Lee Jones wrote:
> > > Fixes the following W=1 kernel build warning(s):
> > > 
> > >  drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
> > >  drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead
> > >  drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead
> > >  drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead
> > > 
> > > Cc: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> > > Cc: Declan Murphy <declan.murphy@...el.com>
> > > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > > Cc: "David S. Miller" <davem@...emloft.net>
> > > Cc: linux-crypto@...r.kernel.org
> > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > > ---
> > 
> > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> > 
> > 
> > Thanks for fixing these.
> > 
> > For some reason, if the issues are there, I don't get those warnings
> > when compiling with W=1; the command I run is:
> > 
> >    make CROSS_COMPILE=<arm-compiler> ARCH=arm64 -j5 W=4 M=drivers/crypto/keembay
> 
> Not sure what would happen with 'W=4'.

Sorry that was a typo (I meant to write W=1) :/

> 
> Probably nothing, as it only goes up to 3 [0].
> 
> > Which command are you running exactly? I'll use it for my next
> > submissions.
> 
>  rm -rf ../builds/build-arm64/drivers/crypto/
>  make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64 allmodconfig
>  make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64  W=1 drivers/crypto/
> 
> Hope that helps.

Thanks for providing your commands. Unfortunately, even if I run them I
don't get the above warnings.

I wonder if the issue is in my version of scripts/kernel-doc (which
seems to be the script called by the Makefile to to check the kernel-
doc).

I'll keep investigating this. Thanks again!

> 
> [0] scripts/Makefile.extrawarn
>