linux-kernel - Re: [PATCH] selftests/vm: rename file run_vmtests to run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6796b330-0a53-284e-83ae-7d7abf1f57f2@nvidia.com>
Date:   Fri, 5 Feb 2021 12:06:02 -0800
From:   John Hubbard <jhubbard@...dia.com>
To:     Rong Chen <rong.a.chen@...el.com>, Shuah Khan <shuah@...nel.org>,
        "Andrew Morton" <akpm@...ux-foundation.org>
CC:     kernel test robot <lkp@...el.com>,
        <linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh

On 2/5/21 12:55 AM, Rong Chen wrote:
> Commit c2aa8afc36fa has renamed run_vmtests in Makefile,
> but the file still uses the old name.
> 
> The kernel test robot reported the following issue:
> 
>   # selftests: vm: run_vmtests.sh
>   # Warning: file run_vmtests.sh is missing!
>   not ok 1 selftests: vm: run_vmtests.sh
> 

I don't know exactly what is going on here, but there was originally a mistake
on my part in renaming run_vmtests to run_vmtests.sh (I was trying to set
the executable bit, which is not always supported by the patch flow), and that 
caused some churn in Andrews's tree. And so maybe that rename got lost/dropped
along the way.

> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: c2aa8afc36fa (selftests/vm: rename run_vmtests --> run_vmtests.sh)
> Signed-off-by: Rong Chen <rong.a.chen@...el.com>
> ---
>   tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} | 0
>   1 file changed, 0 insertions(+), 0 deletions(-)
>   rename tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} (100%)
> 
> diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests.sh
> similarity index 100%
> rename from tools/testing/selftests/vm/run_vmtests
> rename to tools/testing/selftests/vm/run_vmtests.sh
> 

So I guess this is OK, given that I see "run_vmtests" in both -next
and main.

Reviewed-by: John Hubbard <jhubbard@...dia.com>

thanks,
-- 
John Hubbard
NVIDIA