linux-kernel - Re: [PATCH v3] ARM: imx: avic: Convert to using IRQCHIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx9E+dw3HS+DHMhzbrQGcrT6z4kDH=ziS=1=i-7=0rLwgw@mail.gmail.com>
Date:   Thu, 4 Feb 2021 18:07:53 -0800
From:   Saravana Kannan <saravanak@...gle.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Russell King <linux@...linux.org.uk>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Martin Kaiser <martin@...ser.cx>,
        Android Kernel Team <kernel-team@...roid.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

On Thu, Feb 4, 2021 at 5:54 PM Fabio Estevam <festevam@...il.com> wrote:
>
> Hi Saravana,
>
> On Thu, Feb 4, 2021 at 10:39 PM Saravana Kannan <saravanak@...gle.com> wrote:
> >
> > Using IRQCHIP_DECLARE lets fw_devlink know that it should not wait for
> > these interrupt controllers to be populated as struct devices. Without
> > this change, fw_devlink=on will make the consumers of these interrupt
> > controllers wait for the struct device to be added and thereby block the
> > consumers' probes forever. Converting to IRQCHIP_DECLARE addresses boot
> > issues on imx25 with fw_devlink=on that were reported by Martin.
> >
> > This also removes a lot of boilerplate code.
> >
> > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
> > Reported-by: Martin Kaiser <martin@...ser.cx>
> > Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> > Tested-by: Martin Kaiser <martin@...ser.cx>
>
> Thanks for the respin:
>
> Reviewed-by: Fabio Estevam <festevam@...il.com>

Thanks for the quick review.

-Saravana