linux-kernel - [PATCH, v1 1/1] gpio: aspeed: Add gpio base address reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 11:34:50 -0500
From:   Hongwei Zhang <hongweiz@....com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Hongwei Zhang <hongweiz@....com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>, <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-aspeed@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
        <openbmc@...ts.ozlabs.org>
Subject: [PATCH, v1 1/1] gpio: aspeed: Add gpio base address reading


> On Wed, Jan 13, 2021 at 11:38 PM Hongwei Zhang <hongweiz@....com> wrote:
> 
> > Add gpio base address reading in the driver; in old code, it just 
> > returns -1 to gpio->chip.base.
> >
> > Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system")
> > Signed-off-by: Hongwei Zhang <hongweiz@....com>
> 
> NAK, sorry.
> 
> We never allow the device tree to specify this.
> 
> First, it is a Linux-only base so it would have to be a "linux,..." property.
> 
> Even if it is a Linux-only property, it is a bad idea.
> 
> Only people using sysfs should have any need to specify global GPIO numbers. Don't use sysfs. Use the 
> GPIO character device instead. See further:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpio/TODO
> 
> Yours,
> Linus Walleij

Hi Linus,

Thanks for your review and advice.

--Hongwei